Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor based on changes to Operation class in mqt-core #363

Merged
merged 6 commits into from
Apr 4, 2024

Conversation

burgholzer
Copy link
Member

Description

This PR updates DDSIM to the latest mqt-core version that has dropped some long-overdue parameters of functions and members of classes. In particular, the operation classes no longer need the total number of qubits and the starting qubit in order to properly function.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code c++ Anything related to C++ code labels Mar 28, 2024
@burgholzer burgholzer added this to the DDSIM 2.0 milestone Mar 28, 2024
@burgholzer burgholzer self-assigned this Mar 28, 2024
@burgholzer burgholzer enabled auto-merge (squash) March 28, 2024 09:45
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.6%. Comparing base (ec820a6) to head (edb891e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #363     +/-   ##
=======================================
- Coverage   92.8%   92.6%   -0.2%     
=======================================
  Files         37      37             
  Lines       2552    2552             
  Branches     310     309      -1     
=======================================
- Hits        2369    2365      -4     
- Misses       183     187      +4     
Flag Coverage Δ
cpp 94.5% <100.0%> (-0.3%) ⬇️
python 87.7% <ø> (ø)
Files Coverage Δ
src/CircuitSimulator.cpp 90.0% <100.0%> (ø)
src/DeterministicNoiseSimulator.cpp 100.0% <100.0%> (ø)
src/HybridSchrodingerFeynmanSimulator.cpp 97.3% <100.0%> (ø)
src/PathSimulator.cpp 89.0% <100.0%> (ø)
src/ShorFastSimulator.cpp 95.3% <100.0%> (ø)
src/ShorSimulator.cpp 96.1% <100.0%> (-1.2%) ⬇️
src/StochasticNoiseSimulator.cpp 95.6% <100.0%> (ø)

... and 1 file with indirect coverage changes

@burgholzer burgholzer merged commit 01c926f into main Apr 4, 2024
37 checks passed
@burgholzer burgholzer deleted the update-mqt-core branch April 4, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant