Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Code format and linting config update #389

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Conversation

burgholzer
Copy link
Member

Description

This PR updates a couple of the configuration files responsible for code formating, linting, etc.
This brings the project closer to the currently established best practises from mqt-core.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer self-assigned this Jun 20, 2024
@burgholzer burgholzer added the code quality Anything related to code quality and code style. label Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.5%. Comparing base (a80fd38) to head (d11bc62).
Report is 63 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #389     +/-   ##
=======================================
- Coverage   92.5%   92.5%   -0.1%     
=======================================
  Files         37      37             
  Lines       2561    2560      -1     
  Branches     309     309             
=======================================
- Hits        2371    2369      -2     
- Misses       190     191      +1     
Flag Coverage Δ
cpp 94.5% <ø> (-0.1%) ⬇️
python 87.3% <ø> (ø)

see 2 files with indirect coverage changes

@burgholzer burgholzer enabled auto-merge (squash) June 20, 2024 19:50
@burgholzer burgholzer merged commit 9fae916 into main Jun 20, 2024
34 checks passed
@burgholzer burgholzer deleted the code-format-and-linting branch June 20, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Anything related to code quality and code style.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant