Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️🪝 update pre-commit config #414

Merged
merged 5 commits into from
Aug 9, 2024
Merged

⬆️🪝 update pre-commit config #414

merged 5 commits into from
Aug 9, 2024

Conversation

burgholzer
Copy link
Member

Description

This PR adds schema validation to the pre-commit hooks. In addition, it also replaces codespell with crates-ci/typos and fix all newly brought up typos.
Finally, the PR runs pre-commit autoupdate.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added dependencies Pull requests that update a dependency file continuous integration Anything related to the CI setup code quality Anything related to code quality and code style. labels Aug 9, 2024
@burgholzer burgholzer self-assigned this Aug 9, 2024
@burgholzer burgholzer enabled auto-merge (squash) August 9, 2024 08:23
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.6%. Comparing base (a2ce72c) to head (474102c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #414     +/-   ##
=======================================
- Coverage   92.7%   92.6%   -0.1%     
=======================================
  Files         37      37             
  Lines       2725    2724      -1     
  Branches     305     304      -1     
=======================================
- Hits        2527    2525      -2     
- Misses       198     199      +1     
Flag Coverage Δ *Carryforward flag
cpp 94.6% <100.0%> (-0.1%) ⬇️
python 87.3% <ø> (ø) Carriedforward from a2ce72c

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
src/PathSimulator.cpp 88.8% <100.0%> (ø)

... and 2 files with indirect coverage changes

@burgholzer burgholzer merged commit d2733c5 into main Aug 9, 2024
34 checks passed
@burgholzer burgholzer deleted the pre-commit-checks branch August 9, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Anything related to code quality and code style. continuous integration Anything related to the CI setup dependencies Pull requests that update a dependency file
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant