Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rotate): instructions touchups #4259

Merged
merged 12 commits into from
Jun 4, 2024

Conversation

iliapolo
Copy link
Member

@iliapolo iliapolo commented Jun 4, 2024

Minor enhancements / fixes to the rotation instructions doc.

Signed-off-by: Eli Polonsky <epolon@amazon.com>
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
Copy link
Member Author

iliapolo commented Jun 4, 2024

DCO is having issues: dcoapp/app#211. Will probably disable that status check for now to get this merged.

Signed-off-by: Eli Polonsky <epolon@amazon.com>
Signed-off-by: Eli Polonsky <epolon@amazon.com>
Signed-off-by: Eli Polonsky <epolon@amazon.com>
Signed-off-by: Eli Polonsky <epolon@amazon.com>
Signed-off-by: Eli Polonsky <epolon@amazon.com>
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo iliapolo changed the base branch from k8s-29/main to k8s-30/main June 4, 2024 15:25
Signed-off-by: Eli Polonsky <epolon@amazon.com>
Signed-off-by: Eli Polonsky <epolon@amazon.com>
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo iliapolo marked this pull request as ready for review June 4, 2024 15:51
@mergify mergify bot merged commit b7179c8 into k8s-30/main Jun 4, 2024
12 checks passed
@cdk8s-automation
Copy link
Contributor

⚪ Backport skipped

The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.

Manual backport

To create the backport manually run:

backport --pr 4259

Questions ?

Please refer to the Backport tool documentation

@mergify mergify bot deleted the epolon/rotation-instructions-fixes branch June 4, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants