fix(nodebuilder/host): Ensure libp2p metrics are collected to prometheus #3753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
cristaloleg
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3753 +/- ##
==========================================
+ Coverage 44.83% 45.69% +0.85%
==========================================
Files 265 281 +16
Lines 14620 16066 +1446
==========================================
+ Hits 6555 7341 +786
- Misses 7313 7885 +572
- Partials 752 840 +88 ☔ View full report in Codecov by Sentry. |
Wondertan
previously approved these changes
Sep 19, 2024
| // Set the default global registerer to the wrapped one with labels. This way all the metrics | ||
| // registered with the default registerer will be labeled with the provided labels. It is important | ||
| // because unlike libp2p metrics, bitswap metrics are registered with the default global registerer. | ||
| prometheus.DefaultRegisterer = wrapped |
There was a problem hiding this comment.
Aren't bitswap metrics registered on init causing this overwrite being unaffectual?
There was a problem hiding this comment.
You are right, right now it can get racy. Need to ensure order of init:
- update global
- inject bitswap Registrer
- start bitswap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug of prometheus registry not being provided to libp2p constructor as well as few additional improvements of adjustment code:
enableMetrics. It will enable usage of prometheus based metrics, while p2p metrics are disabled