fix(ipld/plugin): verify that data written to namespaceHasher has legit size #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
reviewed
Jul 28, 2022
Wondertan
commented
Jul 28, 2022
|
@renaynay, I can make a test that would just test the hasher itself, but FWIW it does not bring any value. To actually test this, we need somehow simulate that over bitswap we rcv a wrong size msg, which is a big PITA |
Wondertan
force-pushed
the
hlib/fix-hasher
branch
from
ff8d8c0
to
fd5a174
Compare
|
Tests were failing due to a typo. Fixed now |
adlerjohn
reviewed
Jul 31, 2022
liamsi
requested changes
Aug 1, 2022
liamsi
reviewed
Aug 1, 2022
Wondertan
force-pushed
the
hlib/fix-hasher
branch
from
fd5a174
to
df25f4a
Compare
|
An issue to test this out: #981 |
renaynay
reviewed
Aug 2, 2022
Wondertan
force-pushed
the
hlib/fix-hasher
branch
from
df25f4a
to
7f191a4
Compare
Wondertan
force-pushed
the
hlib/fix-hasher
branch
from
7f191a4
to
79bdd33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My understanding of the bug right now is that the bitswap msg that was rcvd from the network had the wrong size of inner nodes hashes, and instead of erroring out, our IPLD plugin panics. It's not clear what could cause the wrong msg size under normal conditions, but it's clear that we have to fix it by checking if the sizes of msgs are correct.
Closes #952 and closes celestiaorg/celestia-core#780