Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: internalize unneeded go apis #92

Merged
merged 6 commits into from
Jul 2, 2024
Merged

chore: internalize unneeded go apis #92

merged 6 commits into from
Jul 2, 2024

Conversation

cmwaters
Copy link
Collaborator

This PR does an initial pass of the share repo and internalizes things like test methods or the Builder struct that should not be public.

Base automatically changed from cal/rename-to-share-pkg to main June 28, 2024 07:53
@cmwaters cmwaters marked this pull request as ready for review June 28, 2024 08:29
@cmwaters cmwaters requested review from a team as code owners June 28, 2024 08:29
@cmwaters cmwaters requested review from staheri14, evan-forbes, Wondertan and vgonkivs and removed request for a team June 28, 2024 08:29
@cmwaters cmwaters self-assigned this Jun 28, 2024
@cmwaters cmwaters requested a review from rootulp June 28, 2024 08:33
rootulp
rootulp previously approved these changes Jun 28, 2024
share/share_builder.go Outdated Show resolved Hide resolved
Co-authored-by: Rootul P <rootulp@gmail.com>
@cmwaters cmwaters merged commit 1ef3988 into main Jul 2, 2024
11 checks passed
@cmwaters cmwaters deleted the cal/internalize branch July 2, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants