Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAP LDAP account attributes to labels such as groups #228

Merged
merged 5 commits into from
Jan 26, 2019

Conversation

mrueg
Copy link
Contributor

@mrueg mrueg commented Apr 12, 2018

Since the original PR went stale, I

@rojer @alonbl Please have another look. Also @kcd83 fyi :)


This change is Reviewable

@alonbl
Copy link
Contributor

alonbl commented Apr 12, 2018

Looks ok!

@mrueg
Copy link
Contributor Author

mrueg commented May 14, 2018

@rojer Friendly ping :)

@jaen
Copy link

jaen commented May 16, 2018

@mrueg is that perchance available somewhere in Dockerhub? Or would I have to build an image on my own?

@mrueg
Copy link
Contributor Author

mrueg commented May 16, 2018

@jaen I've patched it downstream in gentoo, (sys-auth/docker_auth), that's where I'm currently using it.

@jaen
Copy link

jaen commented May 16, 2018

I see, thanks for the info. I guess I'll just build my own image then.

@jaen
Copy link

jaen commented May 16, 2018

@mrueg this is mostly working for me, except for the fact that FreeIPA seems to have types of DN elements lowercased, so I had to modify getCNfromDN to do strings.ToLower on rdnAttr.Type and compare to "cn".

Case-insensitive comparison would be a welcome change so I could use it out-of-the-box.

@rojer
Copy link
Collaborator

rojer commented Jun 1, 2018

@mrueg can you address @jaen 's comment? seems ok and good to go to me otherwise

@aleofreddi
Copy link

aleofreddi commented Jun 13, 2018

For my use case It would be really great to use a regex as well to extract the label value (besides the CN extraction). I could implement that on top of this PR, but is there any hope this one gets merged?

Do you think it makes any sense, and would be the auth_ldap backend the right place for such a feature?

@abaddononion
Copy link

Just starting using the cesanta/docker_auth container, and getting this PR merged would be really helpful for my purposes, as well!

@pinepain
Copy link
Contributor

pinepain commented Jan 23, 2019

@mrueg million thanks for taking care of this!

@jaen would you think that merging this one and then addressing lowercasing CN in a separate PR would be appropriate? Apparently, adding groups filtering has some touch on it and it seems to be this PR have a good change to stale as the original one too.

@jaen
Copy link

jaen commented Jan 25, 2019

Ah, sure. I'm not directly involved with the project that initially required this now, so I don't have any strong feelings on having this included anymore.

@rojer
Copy link
Collaborator

rojer commented Jan 26, 2019

ok, ok, people, i'm on it.
sorry for neglecting this for so long, docker_auth is far from my main LoB and LDAP is even further off.

@rojer rojer merged commit b89dec9 into cesanta:master Jan 26, 2019
@rojer
Copy link
Collaborator

rojer commented Jan 26, 2019

ok, this is now in :latest and :1.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants