-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAP LDAP account attributes to labels such as groups #228
Conversation
Looks ok! |
@rojer Friendly ping :) |
@mrueg is that perchance available somewhere in Dockerhub? Or would I have to build an image on my own? |
@jaen I've patched it downstream in gentoo, (sys-auth/docker_auth), that's where I'm currently using it. |
I see, thanks for the info. I guess I'll just build my own image then. |
@mrueg this is mostly working for me, except for the fact that FreeIPA seems to have types of DN elements lowercased, so I had to modify Case-insensitive comparison would be a welcome change so I could use it out-of-the-box. |
For my use case It would be really great to use a regex as well to extract the label value (besides the CN extraction). I could implement that on top of this PR, but is there any hope this one gets merged? Do you think it makes any sense, and would be the auth_ldap backend the right place for such a feature? |
Just starting using the cesanta/docker_auth container, and getting this PR merged would be really helpful for my purposes, as well! |
@mrueg million thanks for taking care of this! @jaen would you think that merging this one and then addressing lowercasing CN in a separate PR would be appropriate? Apparently, adding groups filtering has some touch on it and it seems to be this PR have a good change to stale as the original one too. |
Ah, sure. I'm not directly involved with the project that initially required this now, so I don't have any strong feelings on having this included anymore. |
ok, ok, people, i'm on it. |
ok, this is now in |
Since the original PR went stale, I
@rojer @alonbl Please have another look. Also @kcd83 fyi :)
This change is