feat: Set license information for packages with rules_license #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should add some tests, but otherwise it's ready for review. |
|
I also want to set |
brentleyjones
force-pushed
the
bj/set-license-information-for-packages-with-rules_license
branch
2 times, most recently
from
13c2078
to
307ba4e
Compare
Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
force-pushed
the
bj/set-license-information-for-packages-with-rules_license
branch
from
307ba4e
to
0abe909
Compare
cgrindel
reviewed
Jun 29, 2024
|
|
||
| # Name won't be set for `package` declarations | ||
| if decl.name: | ||
| parts.extend(scg.new_attr("name", decl.name, indent + 1)) |
There was a problem hiding this comment.
Just to confirm. The case when a name won't be present is the package declaration. Is that correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1092.