Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't exit if we can't remove a file that already doesn't exist #5328

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

msgmaxim
Copy link
Contributor

@msgmaxim msgmaxim commented Oct 14, 2024

Pull Request

Summary

Ran into this when trying to start a new network. The script shouldn't exit if the file we are trying to remove already doesn't exit, and -f achieves this.

@msgmaxim msgmaxim requested a review from a team as a code owner October 14, 2024 01:14
@msgmaxim msgmaxim requested review from ahasna and anton-chain and removed request for a team October 14, 2024 01:14
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71%. Comparing base (73b2773) to head (c622ef6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5328    +/-   ##
======================================
- Coverage     71%     71%    -0%     
======================================
  Files        490     490            
  Lines      85156   85073    -83     
  Branches   85156   85073    -83     
======================================
- Hits       60608   60464   -144     
- Misses     21843   21891    +48     
- Partials    2705    2718    +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

localnet/common.sh Outdated Show resolved Hide resolved
Co-authored-by: anton-chain <anton@chainflip.io>
@kylezs kylezs added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@kylezs kylezs added this pull request to the merge queue Oct 15, 2024
@kylezs
Copy link
Contributor

kylezs commented Oct 15, 2024

hit flaky case which is already tracked

Merged via the queue into main with commit d59eac6 Oct 15, 2024
48 of 49 checks passed
@kylezs kylezs deleted the fix/remove-account-path-without-exit branch October 15, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants