Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add union all clause #408

Merged
merged 2 commits into from
Jun 5, 2021
Merged

Add union all clause #408

merged 2 commits into from
Jun 5, 2021

Conversation

jhchabran
Copy link
Collaborator

No description provided.

@jhchabran jhchabran requested a review from asdine June 4, 2021 18:47
internal/sql/parser/select.go Show resolved Hide resolved
internal/sql/parser/select.go Outdated Show resolved Hide resolved
internal/sql/scanner/scanner_test.go Outdated Show resolved Hide resolved
internal/stream/concat.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2021

Codecov Report

Merging #408 (fdea749) into main (8812a7a) will increase coverage by 0.20%.
The diff coverage is 48.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
+ Coverage   68.15%   68.36%   +0.20%     
==========================================
  Files          82       83       +1     
  Lines        7760     7789      +29     
==========================================
+ Hits         5289     5325      +36     
+ Misses       1809     1792      -17     
- Partials      662      672      +10     
Impacted Files Coverage Δ
internal/query/statement/select.go 87.34% <0.00%> (-2.27%) ⬇️
internal/sql/scanner/token.go 10.71% <ø> (ø)
internal/sql/parser/select.go 57.83% <50.00%> (-1.33%) ⬇️
internal/stream/concat.go 50.00% <50.00%> (ø)
internal/planner/optimizer.go 75.82% <55.55%> (+0.61%) ⬆️
internal/query/query.go 52.87% <0.00%> (+20.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8812a7a...fdea749. Read the comment docs.

@jhchabran jhchabran merged commit c00e6b0 into main Jun 5, 2021
@jhchabran jhchabran deleted the union-all branch June 5, 2021 14:22
@asdine asdine added this to the v0.13.0 milestone Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants