Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed filling index types when loading indices from existing db #434

Merged
merged 5 commits into from
Sep 24, 2021
Merged

Fixed filling index types when loading indices from existing db #434

merged 5 commits into from
Sep 24, 2021

Conversation

KudinovKV
Copy link
Contributor

Closes #433

@asdine
Copy link
Collaborator

asdine commented Sep 23, 2021

Thanks @KudinovKV ! Could you rebase your branch with main please?

@K-Kudinov
Merge branch 'main' into fix-indices
38cd88f 
# Conflicts:
#	internal/catalog/catalog.go
@KudinovKV
Copy link
Contributor Author

Thanks @KudinovKV ! Could you rebase your branch with main please?

Done!

asdine
asdine approved these changes Sep 24, 2021
View reviewed changes
Copy link
Collaborator

@asdine asdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@asdine asdine merged commit fe69c7d into chaisql:main Sep 24, 2021
@asdine asdine mentioned this pull request Sep 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asdine asdine asdine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong index arity after reopen an existing DB(multiple index)
3 participants
@KudinovKV @asdine @K-Kudinov