Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graal] Add support of Graal's CoLic Backend to ELK [File-level + Study] (WIP) #669

Closed

Conversation

inishchith
Copy link
Contributor

@inishchith inishchith commented Jul 23, 2019

Address: inishchith/gsoc#9

TODO:

  • Add tests
  • Update docstrings
  • Update commit description

NOTE:

  • The failing test is due to Graal module not being a part of requirements.txt(dependencies) and is a part of this PR just to check the coverage of new additions.

Signed-off-by: inishchith inishchith@gmail.com

@coveralls
Copy link

coveralls commented Jul 23, 2019

Pull Request Test Coverage Report for Build 1581

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 52 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 68.088%

Files with Coverage Reduction New Missed Lines %
/home/travis/build/chaoss/grimoirelab-elk/grimoire_elk/utils.py 52 60.56%
Totals Coverage Status
Change from base Build 1573: -0.2%
Covered Lines: 5748
Relevant Lines: 8442

💛 - Coveralls

Copy link
Member

@valeriocos valeriocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @inishchith for the PR. Overall it looks OK. I see that some code of the study is similar to the one proposed here: #664. It would be possible to abstract the common logic to a class (e.g., study_evolution) and call it from cocom and colic enrichers?

A similar comment targets the file graal_utils, it would be possible to wrap the variables in graal_utils to methods, which use some variables to set up the query attributes? If this is possible, then we could include these methods in the study_evolution file.

WDYT?

@inishchith
Copy link
Contributor Author

@valeriocos Yes. Agree with your thoughts. Will update the PR once I've worked on it.

Thanks!

Copy link
Member

@valeriocos valeriocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @inishchith! Also this PR looks great. The comments are similar to the PR #664, plus there are some suggestions to reduce redundant code. Let me know what you think.

grimoire_elk/enriched/colic.py Show resolved Hide resolved
grimoire_elk/enriched/colic.py Outdated Show resolved Hide resolved
grimoire_elk/enriched/colic.py Outdated Show resolved Hide resolved
grimoire_elk/enriched/colic.py Outdated Show resolved Hide resolved
grimoire_elk/enriched/colic.py Outdated Show resolved Hide resolved
grimoire_elk/enriched/colic.py Outdated Show resolved Hide resolved
grimoire_elk/enriched/colic.py Show resolved Hide resolved
grimoire_elk/enriched/graal_study_evolution.py Outdated Show resolved Hide resolved
grimoire_elk/enriched/graal_study_evolution.py Outdated Show resolved Hide resolved
grimoire_elk/raw/colic.py Show resolved Hide resolved
@inishchith inishchith force-pushed the gsoc-graal-2019-colic+study branch 2 times, most recently from 3e068d0 to 7fb9cc8 Compare July 27, 2019 09:17
Copy link
Member

@valeriocos valeriocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @inishchith to address my comments. Overall the PR looks great.
I'm not sure whether it's better to unify this PR with #664, since there are common pieces of code, and some modifications cannot be done. WDYT?

grimoire_elk/enriched/colic.py Outdated Show resolved Hide resolved
@inishchith
Copy link
Contributor Author

Thanks for the review @valeriocos.
I was thinking to open a new PR(and close these by referencing them in the newer one) by the following levels of commit:

  1. Requirements
  2. CoCom Integration
  3. CoLic Integration
  4. Segregating common parts out
  5. Tests

Which would allow us to focus on Graal integrations as a whole and testing would become much easier.
Let me know what you think :)

Add support of Graal's CoLic backend to ELK and it's corresponding tests

Signed-off-by: inishchith <inishchith@gmail.com>
@valeriocos
Copy link
Member

You're welcome @inishchith and thanks for proposing the levels of commit :)

I would add a 6. point to add the csvs of the colic and cocom (as reference you can have a look at the git.csv)

@inishchith
Copy link
Contributor Author

closing in reference to #672

@inishchith inishchith closed this Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants