Add HeapBufferType to represent _ddata in Dyno
#26065
Open
+679
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riftEmber
force-pushed
the
dyno-ddata
branch
5 times, most recently
from
1531186
to
b7476be
Compare
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
mppf
approved these changes
Oct 14, 2024
| @@ -230,8 +230,8 @@ class Type { | |||
| } | |||
|
|
|||
| /** returns true for a type that is a kind of pointer */ | |||
| bool isPtrType() const { | |||
| return isClassType() || isCFnPtrType() || isCVoidPtrType() || isCPtrType(); | |||
| bool isAnyPtrType() const { | |||
There was a problem hiding this comment.
Maybe we have to rename it (since isPtrType will now check if it's a subclass of PtrType). But, isAny___ normally checks for "is it the generic type that represents some class of things?" As in, we have AnyImagType as a generic type that means any imag type of any width. So isAnyImagType checks if it is that thing.
I can think of lots of ways out of this situation, but they are all perhaps more of a side trip than I expect you or I want for this PR. E.g., we could rename all of the Any___ types to GenericTypeAny___ or something. If you want to do that, it's fine with me, but needs to be a separate PR.
Calling it isPointerType or isPointerLike or isPtrishType would be the short way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
HeapBufferTypeto represent_ddatain Dyno..eltTypeandthison_ddata.PtrTypeas parent to both this andCPtrType, since they're very similar.HeapBufferTypeanalogous to the testing onCPtrType.Resolves https://github.com/Cray/chapel-private/issues/6777, https://github.com/Cray/chapel-private/issues/6769 and https://github.com/Cray/chapel-private/issues/6768.
[reviewer info placeholder]
Testing: