Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ; to list of shell escaped chars in sub_test.py #26071

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arezaii
Copy link
Contributor

@arezaii arezaii commented Oct 10, 2024

This adds the semicolon character to the list of special escaped characters in two functions we use for preparing test command strings in sub_test.py.

It was needed to accommodate HPO testing where the execopts expect to pass a ; as the delimiter between arguments for the hpo-example.chpl blog article. I found that when start_test was used the program was not seeing any arguments after the first ; in the argsString argument. Manually escaping the character did not work, but adding the ; to the list of escaped characters in these ShellEscape and ShellEscapeCommand did.

TESTING:

  • paratest [Summary: #Successes = 17653 | #Failures = 0 | #Futures = 0]
  • paratest w/gasnet [Summary: #Successes = 17835 | #Failures = 0 | #Futures = 0]

Signed-off-by: Ahmad Rezaii <ahmad.rezaii@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant