Make CHPL_LIB_PATH ignore empty strings #26074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If CHPL_LIB_PATH has colons in it, we split the path based on the colons. However, if we have a trailing or leading colon, or two colons back to back (`::`) in CHPL_LIB_PATH, it get's added as an empty string. This cases errors since there isn't an argument to go with `-L` for the target compiler. This makes the change such the the `addPath` function ignores the empty strings in CHPL_LIB_PATH. Signed-off-by: Shreyas Khandekar <60454060+ShreyasKhandekar@users.noreply.github.com>
ShreyasKhandekar
force-pushed
the
fix_CHPL_LIB_PATH
branch
from
ad26111
to
e90fbc9
Compare
e-kayrakli
approved these changes
Oct 10, 2024
Signed-off-by: Shreyas Khandekar <60454060+ShreyasKhandekar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
CHPL_LIB_PATHhas colons in it, we split the path based on the colons. However, if we have a trailing or leading colon, or two colons back to back (::) in CHPL_LIB_PATH, it get's added as an empty string. This cases errors since there isn't an argument to go with-Lfor the target compiler.Ex:
This makes the change such the the
addPathfunction ignores the empty strings in CHPL_LIB_PATH.Will resolve nightly test failures in
test-gpu-ex-cuda-12.interop.