Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): exclude DeepPartial<unknown[]> from ChartOptions interface #11867

Merged
merged 2 commits into from
Aug 16, 2024
Merged

fix(types): exclude DeepPartial<unknown[]> from ChartOptions interface #11867

merged 2 commits into from
Aug 16, 2024

Conversation

artus9033
Copy link
Contributor

@artus9033 artus9033 commented Aug 16, 2024 •
edited
Loading

This PR solves #11866 by excluding DeepPartial<unknown[]> from ChartOptions.

Closes #11866.

etimberg
etimberg reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change makes sense. Not sure why the CI is failing though since it seems unrelated

@artus9033
Copy link
Contributor Author

Thanks @etimberg! Oh, I can see that now - I haven't run ESLint locally and it seems like my formatting is not compliant with the rules - I'll fix that.

@LeeLenaleee LeeLenaleee added the type: types Typescript type changes label Aug 16, 2024
@LeeLenaleee LeeLenaleee added this to the 4.5.0 milestone Aug 16, 2024
@etimberg etimberg merged commit b51b57a into chartjs:master Aug 16, 2024
8 checks passed
@Tomut0 Tomut0 mentioned this pull request Sep 11, 2024
Merged
@jbrown-xentity jbrown-xentity mentioned this pull request Sep 11, 2024
Merged
@bsimmons123 bsimmons123 mentioned this pull request Sep 11, 2024
Open
@rahatutzaman-rizon rahatutzaman-rizon mentioned this pull request Sep 11, 2024
Open
@MiguelPelegrina MiguelPelegrina mentioned this pull request Sep 11, 2024
Open
@mohamed-helmy22020 mohamed-helmy22020 mentioned this pull request Sep 11, 2024
Open
@diaz-rigo diaz-rigo mentioned this pull request Sep 11, 2024
Open
@respencer respencer mentioned this pull request Sep 11, 2024
Open
@domin-mnd domin-mnd mentioned this pull request Sep 11, 2024
Open
@respencer respencer mentioned this pull request Sep 12, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 12, 2024
Open
@saeedhmohd244 saeedhmohd244 mentioned this pull request Sep 12, 2024
Open
@bagulm123 bagulm123 mentioned this pull request Sep 13, 2024
Open
@opicciotto opicciotto mentioned this pull request Sep 14, 2024
Closed
@mytamDo mytamDo mentioned this pull request Sep 16, 2024
Open
@karencapiiro karencapiiro mentioned this pull request Sep 17, 2024
Open
@bagulm123 bagulm123 mentioned this pull request Sep 18, 2024
Open
@respencer respencer mentioned this pull request Sep 18, 2024
Open
@vigneshshettyin vigneshshettyin mentioned this pull request Sep 18, 2024
Open
@respencer respencer mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

@kurkle kurkle Awaiting requested review from kurkle

Assignees
No one assigned
Labels
type: types Typescript type changes
Projects
None yet
Milestone
Version 4.4.4
Development

Successfully merging this pull request may close these issues.

fix: problem with ChartOptions type
3 participants
@artus9033 @etimberg @LeeLenaleee