-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for netkit device #1257
Conversation
Thanks for this great work! |
@hemanthmalla happy new year! Given 6.7 is officially released now, could you move forward with the PR? Thanks! :) |
bbb1915
to
e53a032
Compare
59e368a
to
7a9c60b
Compare
@lmb I remember reading somewhere, that |
Interesting, I never realized we attached to ifindex 1 in the XDP tests, but that obviously won't work for netkit. I think newer versions of Go automatically prune testing-only module dependencies, so technically there wouldn't be any downside to importing e.g. I think we can soften our stance on importing a netlink lib for testing if this is the case. Not sure if we can do the same for examples. I think shelling out to |
f806346
to
ceb0c7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, only some small requests. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one small nit.
Signed-off-by: Hemanth Malla <hemanth.malla@datadoghq.com>
Test failures seem flaky to me. Previously only |
Adds support for attaching bpf programs to netkit devices using bpf links.
Generated code is currently based on
6.7-rc4
TODO :
netkit
device in CI for testing.6.7
is out and validate for any changes.