Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font size styles (.text-*) do not use .ck-content prefix #6636

Closed
Reinmar opened this issue Apr 21, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-font#63
Closed

Font size styles (.text-*) do not use .ck-content prefix #6636

Reinmar opened this issue Apr 21, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-font#63
Assignees
@panr
Labels
package:font type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 31 (v19...

Comments

@Reinmar
Copy link
Member

Reinmar commented Apr 21, 2020 •
edited
Loading

📝 Provide detailed reproduction steps (if any)

As described. They are content styles so they should be prefixed with .ck-content. Because of that they are missing in https://ckeditor.com/docs/ckeditor5/latest/builds/guides/integration/content-styles.html (this page is updated before every release so it's not part of this task).
@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. package:font labels Apr 21, 2020
@Reinmar Reinmar modified the milestones: iteration 32, iteration 31 Apr 21, 2020
@panr panr mentioned this issue Apr 21, 2020
Merged
oleq added a commit to ckeditor/ckeditor5-font that referenced this issue Apr 22, 2020
@oleq
Merge pull request #63 from ckeditor/i/6636
b0b06db 
Fix: Font size styles should be prefixed by the `.ck-content` class. Closes ckeditor/ckeditor5#6636.
mlewand pushed a commit that referenced this issue May 1, 2020
@oleq
Merge pull request #63 from ckeditor/i/6636
0380bde 
Fix: Font size styles should be prefixed by the `.ck-content` class. Closes #6636.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@panr panr

Labels
package:font type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 31 (v19.0.0)
Development

Successfully merging a pull request may close this issue.

i/6636: Prefix font styles with the .ck-content class. ckeditor/ckeditor5-font
2 participants
@Reinmar @panr