Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visibility and display properties merged together #674

Closed
jeremylevy opened this issue Sep 19, 2015 · 2 comments
Closed

Visibility and display properties merged together #674

jeremylevy opened this issue Sep 19, 2015 · 2 comments
Labels
bug

Comments

@jeremylevy
Copy link

Hello,

Visibility and display properties seem to be merged together:

var CleanCSS = require('clean-css');

new CleanCSS().minify('.b { display: none } .b { display: none; visibility: hidden; }').styles;

-> .b{visibility:hidden}

Thanks!
@jakubpawlowicz
Copy link
Collaborator

It's a bug indeed. Fix is coming!

jakubpawlowicz added a commit that referenced this issue Sep 20, 2015
@jakubpawlowicz
Fixes #674 - adjacent merging order.
2ba023d 
There was an edge case merging two same, adjacent properties when
both were removed from the output.
@jakubpawlowicz
Copy link
Collaborator

Fixed in 3.4.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakubpawlowicz @jeremylevy