Bugfix - Article.contentTagIds field now List<String> - resolves #581 #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dbees-oss#581 The Article.contentTagIds field had been added with the incorrect type of List<Long> (because of misleading Zendesk documentation), but the IDs are actually `String`s & so can't be deserialised to Longs
duemir
approved these changes
May 3, 2023
johnou
approved these changes
May 9, 2023
There was a problem hiding this comment.
lgtm matches documentation here https://developer.zendesk.com/api-reference/help_center/help-center-api/articles/
PierreBtz
approved these changes
May 15, 2023
PierreBtz
added
enhancement
breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Article.contentTagIds field had been added with the incorrect type of List (because of misleading Zendesk documentation), but the IDs are actually
Strings & so can't be deserialised to Longs