Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect log method in README.md #1005

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

Vedadiyan
Copy link
Contributor

log.Fatal is mistakenly used in the following example (in the README file) which should be actually Println

func main() {
    // The default client is HTTP.
    c, err := cloudevents.NewClientHTTP()
    if err != nil {
	    log.Fatalf("failed to create client, %v", err)
    }
    log.Fatal(c.StartReceiver(context.Background(), receive));
} 

README.md Outdated Show resolved Hide resolved
Copy link
Member

@embano1 embano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for spotting this! One small comment

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@embano1 embano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please squash and sign your commits before merging?

Signed-off-by: Pouya Vedadiyan <vedadiyan@gmail.com>
@Vedadiyan
Copy link
Contributor Author

I just squashed all the commits into one commit only

@embano1 embano1 merged commit 998919d into cloudevents:main Jan 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants