Remove intermediary reader and directly feed iterator for unmarshal #626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not streaming the data, we might as well just use jsoniter's pools as intended and feed the iterator with the ready-to-go byte slice directly.
Kept the reader interface intact for enhancements on the streaming side.
Signed-off-by: Markus Thömmes markusthoemmes@me.com
Benchmark
Not a huge difference at all but 🤷♂️. Seemed worth to use the lib as inteded (with the non-buffered iterator pool)