add native disk resize #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgandon
requested changes
Oct 20, 2021
| }) | ||
|
|
||
| It("returns an error if diskService resize call returns an error", func() { | ||
| diskService.ResizeErr = errors.New("fake-disk-service-error") |
There was a problem hiding this comment.
Would read better if moved into a BeforeEach of a surrounding Context("diskService resize call returns an error", ……).
|
|
||
| if disk.SizeGb == newsizeGB.SizeGb { | ||
| d.logger.Debug(googleDiskServiceLogTag, "Skipping resize Google Disk '%s', becasue current value '%s'is equal to new value '%s'", id, disk.SizeGb, newsizeGB) | ||
| } else if disk.SizeGb > newsizeGB.SizeGb { |
There was a problem hiding this comment.
Would be nice to add a test case for disk.SizeGb == newsizeGB.SizeGb and disk.SizeGb > newsizeGB.SizeGb…
I can help in possible refactoring that would help mocking d.Find() and disk.
src/bosh-google-cpi/google/disk_service/google_disk_service_resize.go
Outdated
Show resolved
Hide resolved
bgandon
approved these changes
Oct 21, 2021
|
LGTM, Thanks @ramonskie |
rkoster
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add native disk resize
as the new agent now supports this see cloudfoundry/bosh-agent#244