Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update otel collector example vars file #1203

Conversation

mkocher
Copy link
Member

@mkocher mkocher commented Sep 9, 2024

What customer problem is being addressed? Use customer persona to define the problem e.g. Alana is unable to...

  • add file examples for each signal type
  • comment out otlp examples as they are not valid unless updated with a real collector/backend to send to

Has a cf-deployment including this change passed cf-acceptance-tests?

  • YES
  • NO

Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.

  • YES - please choose the category from below. Feel free to provide additional details.
  • NO

How should this change be described in cf-deployment release notes?

Example otel collector vars file now has examples for all signal types

Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?

  • YES - please specify
  • NO

Does this PR make a change to an experimental or GA'd feature/component?

  • experimental feature/component
  • GA'd feature/component

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

- add file examples for each signal type
- comment out otlp examples as they are not valid unless updated with a
  real colletor/backend to send to

Signed-off-by: Carson Long <12767276+ctlong@users.noreply.github.com>
@ctlong ctlong self-assigned this Sep 9, 2024
@jochenehret jochenehret merged commit 73119eb into cloudfoundry:develop Sep 10, 2024
3 checks passed
@ctlong ctlong deleted the update-otel-collector-example-vars branch September 10, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants