New SAML 2024.05.30 - Not to merge but just for SAML feature branch testing #2908
+23,127
−17,634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tallicia
added
in progress
DO NOT MERGE
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187710947 The labels on this github issue will be updated when the story is started. |
Tallicia
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ava/org/cloudfoundry/identity/uaa/provider/saml/SamlLegacyAliasResponseForwardingFilter.java
Fixed
Show fixed
Hide fixed
duanemay
force-pushed
the
new-saml-0530
branch
5 times, most recently
from
65b0d64
to
e67a40a
Compare
duanemay
force-pushed
the
new-saml-0530
branch
9 times, most recently
from
a761b67
to
7de27a1
Compare
duanemay
force-pushed
the
new-saml-0530
branch
2 times, most recently
from
0d3a595
to
f199f50
Compare
peterhaochen47
force-pushed
the
new-saml-0530
branch
from
46248b9
to
290f89c
Compare
duanemay
force-pushed
the
new-saml-0530
branch
2 times, most recently
from
46248b9
to
b6cb65b
Compare
peterhaochen47
force-pushed
the
new-saml-0530
branch
2 times, most recently
from
a97457f
to
745fff3
Compare
This comes from the property, login.saml.nameID Also refactored the RelyingPartyRegistrationBuilder to use a Params object with builder since the param list was 8 items TPCF-6874 Signed-off-by: Duane May <duane.may@broadcom.com>
TPCF-6882 Signed-off-by: Duane May <duane.may@broadcom.com>
make it easier to find the failed tests in output Signed-off-by: Duane May <duane.may@broadcom.com>
Guava Cache recommends moving to Caffeine Mostly a drop in replacement Although the refreshAfterWrite works a little different Signed-off-by: Duane May <duane.may@broadcom.com>
The mechanism to achieve this in the old SAML library is no longer there. Added this in to the SamlLoginAuthenticationFailureHandler. Left the logger name as SamlResponseLoggerBinding for backward compatibility, for jobs looking for the messages. [TPCF-25429] Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
maintains existing functionality Signed-off-by: Duane May <duane.may@broadcom.com>
SamlLoginIT.springSamlEndpointsWithEmptyContext - functionality changed redirects ZoneAwareKeyManagerTest - was 0 coverage, all calls are proxied to SamlKeyManager in the ThreadLocal managed by IdentityZoneHolder. Signed-off-by: Duane May <duane.may@broadcom.com>
Replace the //NOSONAR comment with a error specific SuppressWarnings annotation
duanemay
force-pushed
the
new-saml-0530
branch
from
c0bfaea
to
dbbd346
Compare
Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing the other feature branch #2862 for new SAML library replacement effort.