Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Couple of failing test cases due to 500 INTERNAL_SERVER_ERROR #2978

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

hsinn0
Copy link
Contributor

@hsinn0 hsinn0 commented Jul 25, 2024

…from /oauth/token endpoint

  • Stepping through the server code revealed that an exception was thrown as follows:
org.cloudfoundry.identity.uaa.util.JsonUtils$JsonUtilException: com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "relyingPartyRegistrationId" (class org.cloudfoundry.identity.uaa.authentication.UaaPrincipal), not marked as ignorable (6 known properties: "origin", "zoneId", "id", "email", "externalId", "name"])
at [Source: REDACTED (StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION disabled); line: 1, column: 205] (through reference chain: org.cloudfoundry.identity.uaa.authentication.UaaPrincipal["relyingPartyRegistrationId"])
  • Added a jackson annotation to ignore the 3 properties in UaaSamlPrincipal that were causing the UnrecognizedPropertyException.
  • Added back a line that sets zoneId in a test case, which apparently had been removed by mistake.

[#187986233]
[#187986220]

…from `/oauth/token` endpoint

- Stepping through the server code revealed that an exception was thrown as follows:
```
org.cloudfoundry.identity.uaa.util.JsonUtils$JsonUtilException: com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "relyingPartyRegistrationId" (class org.cloudfoundry.identity.uaa.authentication.UaaPrincipal), not marked as ignorable (6 known properties: "origin", "zoneId", "id", "email", "externalId", "name"])
at [Source: REDACTED (StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION disabled); line: 1, column: 205] (through reference chain: org.cloudfoundry.identity.uaa.authentication.UaaPrincipal["relyingPartyRegistrationId"])
```
- Added a `jackson` annotation to ignore the 3 properties in UaaSamlPrincipal that were causing the `UnrecognizedPropertyException`.
- Added back a line that sets zoneId in a test case, which apparently had been removed by mistake.

[#187986233]
[#187986220]
@hsinn0
Copy link
Contributor Author

hsinn0 commented Jul 25, 2024

I did verify that all unit & integration tests were passing.

@hsinn0 hsinn0 marked this pull request as ready for review July 25, 2024 22:17
@hsinn0 hsinn0 requested a review from duanemay July 25, 2024 22:18
@duanemay
Copy link
Member

👍

@duanemay duanemay merged commit f61f842 into new-saml-0530 Jul 26, 2024
3 checks passed
@duanemay duanemay deleted the new-saml-fix-oauth-token-endpoint-500 branch July 26, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants