HDR Enhancements for God of War (2018) #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses significant issues with God of War's original HDR implementation, introducing improvements in tonemapping, gamma correction, brightness control, and color grading. These changes ensure a more accurate and immersive HDR experience while offering users enhanced control over visual settings.
Key Changes
HDR Improvements:
Tonemapping Options:
Adjustable Sliders:
Color Grading Sliders:
Known Issue
The game writes to an
rgb10a2_unorm
texture at the end of the rendering pipeline. At this stage, the UI and game image is already blended, and a final scalar is applied to the entire image (one was previously applied to the final game render). This allows independent control over the game and UI brightness, as finding and editing each UI shader individually would be impractical. However, applying this scalar to an image already clamped to 10,000 nits and then tonemapping it results in a slight reduction of peak brightness as the UI brightness slider is lowered.Additional Notes
God of War (2018)'s original HDR implementation suffered from poor handling of HDR content, including incorrect gamma (sRGB instead of 2.2), no peak brightness handling, and a poor approximation of PQ. These issues are now resolved.
The updated HDR mod has been tested extensively in various sections of the game, ensuring it enhances the visual experience while maintaining the integrity of the original artistic direction.