Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add clusterimportpolicy example for kubevela #243 #421

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

muma378
Copy link
Contributor

@muma378 muma378 commented Oct 12, 2022

Signed-off-by: Xiao Yang muma.378@163.com

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Add an example to show how to import clusters added from kubevela.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@clusterpedia-bot
Copy link

Hi @muma378,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@clusterpedia-bot clusterpedia-bot added the kind/documentation Improvements or additions to documentation label Oct 12, 2022
Copy link
Member

@Iceber Iceber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for contributing, there are some that need to be updated, the others look good to me.

deploy/clusterimportpolicy/kubevela.yaml Outdated Show resolved Hide resolved
- "configmaps"
- group: apps
resources:
- deployments
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually synchronize these resources by default

        - group: ""
          resources:
            - "pods"
            - "services"
            - "configmaps"
            - "secrets"
            - "namespaces"
            - "nodes"
        - group: "apps"
          resources:
            - "*"

deploy/clusterimportpolicy/kubevela.yaml Outdated Show resolved Hide resolved
Signed-off-by: Xiao Yang <muma.378@163.com>
@Iceber
Copy link
Member

Iceber commented Oct 27, 2022

/lgtm
@muma378 Thank you for adding the kubevela import policy

@clusterpedia-bot clusterpedia-bot added the lgtm Look good to me label Oct 27, 2022
@Iceber Iceber merged commit c00a76d into clusterpedia-io:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation lgtm Look good to me size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants