Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add devcontainer configuration #443

Merged
merged 4 commits into from
May 21, 2023

Conversation

hsloot
Copy link
Contributor

@hsloot hsloot commented May 2, 2023

what is this pull request about?

Add a devcontainer configuration that allows using Github's Codespaces feature or using devcontainers with vscode.

does this relate to an existing issue?

See #442

does this change any existing behavior?

no

what does this add?

  • Seamless development for without Perl administration

@github-actions
Copy link

github-actions bot commented May 2, 2023

Thank you for your contribution! Please can you change this pull request so that it goes to the develop branch? Thank you

@hsloot hsloot changed the base branch from main to develop May 2, 2023 19:56
hsloot added 2 commits May 2, 2023 23:40
The directory `~/Desktop` requires the existence of a non-root user.
ENV LANG=en_US.UTF-8
RUN locale-gen en_US.UTF-8

RUN cpanm YAML::Tiny && \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably could be changed to use the helper script; when writing this, I had some issues with the interactive mode, but I think this part could be replaced by code similar to the other Dockerfile.

&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*

ENV LC_ALL=en_US.UTF-8
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had problems using cpanm since it reported errors due to unset locales and had to include these settings. However, your other Dockerfile does not set these either and seems to work. I am not expert enough to judge whether this here is unnecessary or whether similar settings should be set in the other Dockerfile.

latexindent.pl -s cruft-directory1 -c ~/Desktop/tmp/ -w -g=one.log
latexindent.pl -s cruft-directory1 -c ~/Desktop/tmp/ -w -g=two.log
latexindent.pl -s cruft-directory1 -c ~/Desktop/tmp/ -w -l=more-than-one-back-up.yaml -g=three.log
latexindent.pl -s cruft-directory1 -c $(mktemp -d) -w -g=one.log
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default container has no user besides root; consequently, ~/Desktop does not exist.

cmake \
git \
wget \
locales \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to install the packages locals and locales-all; see other comments.

@hsloot hsloot marked this pull request as ready for review May 21, 2023 19:16
@cmhughes cmhughes merged commit 0dbd150 into cmhughes:develop May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants