Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tables for map version 160812 for 3 and 3.8 T #1

Merged
merged 1 commit into from
Jun 7, 2017

Conversation

namapane
Copy link
Contributor

@namapane namapane commented Jun 7, 2017

For future field maps. No change in existing functionality or current default behavior.
cf: https://indico.cern.ch/event/642366/contributions/2606389/

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

A new Pull Request was created by @namapane (Nicola Amapane) for branch master.

@cmsbuild, @smuzaffar, @mrodozov, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

external issue cms-sw/cmsdist#3094

@davidlange6
Copy link

I belatedly notice - 22k files (11k per map?).. can we not condense these somewhat?

@davidlange6
Copy link

ok, i guess this is continuing an old design...

find /cvmfs/cms.cern.ch/slc6_amd64_gcc530/cms/data-MagneticField-Interpolation/V01-00-00/MagneticField/Interpolation/data/grid_130503_3_8t_v9_small | wc
9662 9662 1555410

@smuzaffar
Copy link

smuzaffar commented Jun 13, 2017

right, currently in tag V01-00-00 we have 48K files with total size of 380MB

@namapane
Copy link
Contributor Author

namapane commented Jun 13, 2017 via email

@namapane
Copy link
Contributor Author

I picked a recent nightly build and I find this under $CMSSW_DATA_PATH/data-MagneticField-Interpolation/V00-00-01/... and it works.
However, I also see that $CMSSW_DATA_PATH/data-MagneticField-Interpolation/V00-00-00/... exists, which is also populated. What is the reason for keeping both? In this way a good fraction of this large number of files is distributed twice, which does not seem to make a lot of sense.

@slava77
Copy link

slava77 commented Jun 23, 2017 via email

@namapane
Copy link
Contributor Author

Yes but in this case V00-00-01 contains exactly the same files of V00-00-00, plus two sets in addition which do not interfere with supported past releases. There is really no point in duplicating these 48k files, couldn't we have added the new files and created a new set only when we really break backward compatibility (ie remove old sets that are still used in supported past releases).

Moreover, I'm probably missing something but how does a recent CMSSW version know that it should look at V00-00-01 and not at V00-00-00? Both are found under CMSSW_DATA_PATH.

In any case, Slava Kl has prepared the last two map sets much earlier than expected, and I would like to add these as well, will this result in a V00-00-02 and yet another copy of all the files, or can we update (or drop) V00-00-01 given it did not go to an actual release yet?

@slava77
Copy link

slava77 commented Jun 23, 2017 via email

@slava77
Copy link

slava77 commented Jun 23, 2017

the incremental solution would be to instead distribute every field map version subdirectory as a separate external

@namapane
Copy link
Contributor Author

namapane commented Jun 27, 2017 via email

@slava77
Copy link

slava77 commented Jun 27, 2017

It would be good to get some feedback here from David and Shahzad.
@davidlange6 @smuzaffar

@davidlange6
Copy link

davidlange6 commented Jun 27, 2017 via email

@smuzaffar
Copy link

@namapane, as @slava77 mentioned, if we want to avoid duplication then we have to bundle these maps in separate externals which means you have to update cmssw code too. How much more data you would like to include ? Note that data-MagneticField-Interpolation github repo is nearly 500MB now and there is 1GB size limitation on github repos.

@namapane
Copy link
Contributor Author

namapane commented Jun 28, 2017 via email

@smuzaffar
Copy link

I am fine with keeping these in single external.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants