Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ONNX file for FastSim refinement backport for Run 2 DeepJet tagging #15

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

sbein
Copy link

@sbein sbein commented Apr 19, 2023

The added file complements the CMSSW backport cms-sw/cmssw#40828, which implements the FastSim refinement of the DeepJet collections.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 19, 2023

A new Pull Request was created by @sbein (Sam Bein) for branch CMSSW_10_6_X.

@smuzaffar, @swertz, @vlimant, @aandvalenzuela, @iarspider, @cmsbuild, @simonepigazzini can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

+externals
This is backport of #14 . It adds a new files for 10.6.X, so should be safe to already include in 10.6.X externals

@cmsbuild
Copy link
Contributor

Pull request #15 was updated.

@sbein
Copy link
Author

sbein commented May 12, 2023

Hi @smuzaffar, I just refreshed the model with Moritz's latest onnx file. Can we merge this soon? Thnxs.

@smuzaffar
Copy link
Contributor

@sbein , I think it is better to rerunthe tests for cms-sw/cmssw#40828 with this updated data

@sbein
Copy link
Author

sbein commented Jul 7, 2023

we need to merge this I think +1

@perrotta
Copy link

perrotta commented Jul 7, 2023

@aandvalenzuela I think we should have run the usual tests before merging: this was updated on May 12, and never tested since then!

@aandvalenzuela
Copy link

Sorry @perrotta! I though it was already tested by cms-sw/cmssw#40828 (that was already merged three weeks ago).
Should I revert the merge? Sorry for the inconvenience.

@perrotta
Copy link

perrotta commented Jul 7, 2023

Sorry @perrotta! I though it was already tested by cms-sw/cmssw#40828 (that was already merged three weeks ago). Should I revert the merge? Sorry for the inconvenience.

Ah, ok. Yes, it was tested with #40828, and just forgot while merging that one.
Then, no problem: this merge completes the one of #40828.
Sorry for the noise, and thank you!

@srimanob
Copy link

Hi @smuzaffar @perrotta @rappoccio @sbein @antoniovilela

I confuse a bit on this PR and CMSSW_10_6_35. Currently, the production stuck because of missing model, btagDeepFlavRefineNN_CHS.onnx, issue. See here). However, I see it in
https://github.com/cms-data/PhysicsTools-NanoAOD/tree/CMSSW_10_6_X

Do we somehow miss something?

Thx.

@srimanob
Copy link

Ah, I think I know. We need CMSSW_10_6_36, which include Update tag for PhysicsTools-NanoAOD to V01-01-00-01-00 [10_6_X]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants