Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weights for HZZ ID #28

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

apetkovi1
Copy link

@apetkovi1 apetkovi1 commented Nov 13, 2023

This PR is to add weights for Run3 HZZ electron ID

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 13, 2023

A new Pull Request was created by @apetkovi1 (Andro Petkovic) for branch master.

@mandrenguyen, @jfernan2, @iarspider, @aandvalenzuela, @cmsbuild, @smuzaffar can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

only new data files, should be tested and merged along with cms-sw/cmssw#43430

@a-kapoor
Copy link

only new data files, should be tested and merged along with cms-sw/cmssw#43430

sorry @smuzaffar I am unable to understand this comment. This PR only contains new files.

@smuzaffar
Copy link
Contributor

@a-kapoor , comment was to remind myself to not start the tests here :-) Testing data PRs with only new files makes no sense as tests are always going to pass.

@a-kapoor
Copy link

@a-kapoor , comment was to remind myself to not start the tests here :-) Testing data PRs with only new files makes no sense as tests are always going to pass.

Perfect! Thanks. :-)

@mmusich
Copy link

mmusich commented Jan 16, 2024

Looks like cms-sw/cmssw#43430 was merged without this, which (as usual) is causing massive IB failures.

@a-kapoor
Copy link

Looks like cms-sw/cmssw#43430 was merged without this, which (as usual) is causing massive IB failures.

Oops! I believe the way out here is to backport the cmsdist PR after merging this one? Do we need to make the PR? @smuzaffar would you please to help us with how to proceed? Sorry we didn't realize this was still not merged.

@smuzaffar
Copy link
Contributor

+externals

@rappoccio, @antoniovilela this should have been merged along with cms-sw/cmssw#43430 . I am force merging it to get it in 11h IB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants