Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for cmsTritonPostBuild checks for data externals #2143

Closed
wants to merge 4 commits into from

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Jan 11, 2024

This allows bot to create cmsdist/data/data-Repo-Name.file with contents like [a] for CMS data externals which contain config.pbtxt file(s). Bot will only add/create this if cmsdist branch already contains data/cmsTritonPostBuild.file.

FYI @kpedro88

[a]

## INCLUDE data/cmsTritonPostBuild

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch master.

@smuzaffar, @aandvalenzuela, @cmsbuild, @iarspider can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 11, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #2143 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2143 was updated.

@smuzaffar
Copy link
Contributor Author

please test with cms-data/HeterogeneousCore-SonicTriton#3

as cmsdist is missing rhe extra cmsTriton* files so this test is not going to run the cmsTritonChecksumTool

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8487d6/36800/summary.html
COMMIT: 9317c5f
CMSSW: CMSSW_14_0_X_2024-01-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2143/36800/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8487d6/36800/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8487d6/36800/git-merge-result

Comparison Summary

Summary:

@kpedro88
Copy link
Contributor

@smuzaffar I think this can be closed now that the plan is simplified

@smuzaffar
Copy link
Contributor Author

closing this as it is not needed any more

@smuzaffar smuzaffar closed this Jan 17, 2024
@smuzaffar smuzaffar deleted the cmsTritonPostBuild branch February 16, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants