Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept progress labels for cms-docker issues #2156

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Accept progress labels for cms-docker issues #2156

merged 4 commits into from
Jan 25, 2024

Conversation

aandvalenzuela
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch master.

@aandvalenzuela, @iarspider, @cmsbuild, @smuzaffar can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 23, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #2156 was updated.

1 similar comment
@cmsbuild
Copy link
Contributor

Pull request #2156 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2156 was updated.

1 similar comment
@cmsbuild
Copy link
Contributor

Pull request #2156 was updated.

smuzaffar
smuzaffar reviewed Jan 24, 2024
View reviewed changes
process_pr.py Outdated Show resolved Hide resolved
smuzaffar
smuzaffar reviewed Jan 24, 2024
View reviewed changes
process_pr.py Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

Pull request #2156 was updated.

1 similar comment
@cmsbuild
Copy link
Contributor

Pull request #2156 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2156 was updated.

1 similar comment
@cmsbuild
Copy link
Contributor

Pull request #2156 was updated.

@aandvalenzuela
Accept state labels for tracking a process
79981b1 
Accept process labels

Fix append

Fix style

Correct labels dict

Match only one label at a time

Apply code review

Apply code review

Apply formatting

Change regex
@cmsbuild
Copy link
Contributor

Pull request #2156 was updated.

smuzaffar
smuzaffar reviewed Jan 25, 2024
View reviewed changes
process_pr.py Outdated Show resolved Hide resolved
smuzaffar
smuzaffar reviewed Jan 25, 2024
View reviewed changes
process_pr.py Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

Pull request #2156 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2156 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2156 was updated.

@smuzaffar
Copy link
Contributor

+externals

done tests for cms-sw/cms-docker#266 and bot process the new state types correctly

@smuzaffar smuzaffar merged commit fea242d into cms-sw:master Jan 25, 2024
3 of 4 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@iarspider iarspider mentioned this pull request Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smuzaffar smuzaffar smuzaffar left review comments

Assignees
No one assigned
Labels
externals-approved fully-signed orp-pending tests-pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aandvalenzuela @cmsbuild @smuzaffar