Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scram-tools: Fix for replacing @VAR@ in toolfile; remove PGO-Profiles subdir #8944

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

smuzaffar
Copy link
Contributor

Thsi fixes the PGO issue where existing regexp was changing @{CMSSW_PGO_DIRECTORY}/PGO-Profiles/cmssw/@{CMSSW_CPU_TYPE} to {CMSSW_CPU_TYPE}

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_14_0_X/master.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 16, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #8944 was updated.

@smuzaffar smuzaffar changed the title scram-tools: Only replace @VAR@ scram-tools: Fix for replacing @VAR@ in toolfile; remove PGO-Profiles subdir Jan 16, 2024
@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #8944 was updated.

@smuzaffar
Copy link
Contributor Author

+externals

gcc-cxxcompiler and intel-license tools now have correct values

./intel-license.xml:    <runtime name="INTEL_LICENSE_FILE" value="28518@lxlicen01.cern.ch,28518@lxlicen02.cern.ch,28518@lxlicen03.cern.ch" handler="warn"/>
./gcc-cxxcompiler.xml:    <flags PGO_USE_FLAGS="-fprofile-use=@{CMSSW_PGO_DIRECTORY}/cmssw/@{CMSSW_CPU_TYPE} -fprofile-partial-training"/>

@smuzaffar smuzaffar merged commit 2e3d709 into IB/CMSSW_14_0_X/master Jan 16, 2024
5 of 8 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-619abd/36853/summary.html
COMMIT: fa64018
CMSSW: CMSSW_14_0_X_2024-01-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8944/36853/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-619abd/36853/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-619abd/36853/git-merge-result

Comparison Summary

Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants