Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT628] Update ROOT to tip of branch v6-28-00-patches #8977

Conversation

aandvalenzuela
Copy link
Contributor

No description provided.

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_14_0_X/root628.

@aandvalenzuela, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 30, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #8977 was updated.

@smuzaffar
Copy link
Contributor

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a61a72/37113/summary.html
COMMIT: 01d1d44
CMSSW: CMSSW_14_0_ROOT628_X_2024-01-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8977/37113/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a61a72/37113/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a61a72/37113/git-merge-result

Unit Tests

I found 2 errors in the following unit tests:

---> test TestIOPoolInputNoParentDictionary had ERRORS
---> test testG4Refitter had ERRORS

Comparison Summary

Summary:

  • You potentially removed 235 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1079 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248611
  • DQMHistoTests: Total failures: 24732
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3223857
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.546 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 141.042,... ): 0.182 KiB HLT/Filters
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 3 / 46 workflows

@smuzaffar
Copy link
Contributor

+externals

good to go in root628. The unit test normally failed during PR tests with full cmssw re-build and root version update

@smuzaffar smuzaffar merged commit e60961d into cms-sw:IB/CMSSW_14_0_X/root628 Jan 31, 2024
9 of 10 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/root628 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants