Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update urllib3 to fix 2 dependabot issues #9250

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master.

@iarspider, @aandvalenzuela, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 18, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test for slc7_amd64_gcc12

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ce9f9/39937/summary.html
COMMIT: 283dfb8
CMSSW: CMSSW_14_1_X_2024-06-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9250/39937/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345018
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3344995
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit 5bdd343 into IB/CMSSW_14_1_X/master Jun 18, 2024
14 of 15 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ce9f9/39938/summary.html
COMMIT: 283dfb8
CMSSW: CMSSW_14_1_X_2024-06-17-2300/slc7_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9250/39938/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 262 lines to the logs
  • Reco comparison results: 62290 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345018
  • DQMHistoTests: Total failures: 148091
  • DQMHistoTests: Total nulls: 302
  • DQMHistoTests: Total successes: 3196605
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.5399999999999996 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.308 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): 2.381 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 140.043 ): -0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.042 ): 0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): -0.035 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): -0.182 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.064 KiB SiStrip/MechanicalView
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 14 / 46 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants