Fix multi-command handling and add tests #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @kpedro88 (Kevin Pedro) for branch master. @cmsbuild, @iarspider, @aandvalenzuela, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
thanks a lot @kpedro88 . This look good |
|
+externals |
cmsbuild
added
fully-signed
externals-approved
and removed
pending-signatures
externals-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue reported in https://cms-talk.web.cern.ch/t/issue-with-command-to-run-in-cmssw-cc7-singularity/32815/, while still allowing the use of arguments not surrounded by quotes in the single-command, multi-argument case.
Adds tests for various behavior, including the tests used in #3 and #4. Also fixes the "standalone" (non-cvmfs) case, which had been inadvertently left broken in #4.