-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support to multi layout portable collections (up to 5)
The design is recursive, but ROOT seems not to serialize variadic templates, so we have a
5 elements design. This number is arbitrary and can be changed with relatively little work.
The order of the PortableDeviceCollection template parameters is changed from device at the end
to device at the begining to accomodate the pseudo variadic templation.
A test validates the colleciton with two layouts and three layouts.
The layout and view can be accessed by index or type, on the condition the type is present only
once in the collection.
The default index is set to 0 to minimize the need for chages in the single layout case. Empty
template parameters square bracket ("<>") are needed in some cases.
Convenience scripts are added to generate the XML need for dictionary generation but has to be edited
if there are commonalities between multiple collections.- Loading branch information
Showing
29 changed files
with
1,372 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
103 changes: 103 additions & 0 deletions
103
DataFormats/Portable/interface/PortableCollectionCommon.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| #ifndef DataFormats_Portable_interface_PortableCollectionCommon_h | ||
| #define DataFormats_Portable_interface_PortableCollectionCommon_h | ||
|
|
||
| #include <cstddef> | ||
| #include <type_traits> | ||
| #include <array> | ||
|
|
||
| namespace portablecollection { | ||
|
|
||
| // Note: if there are other uses for this, it could be moved to a central place | ||
| template <std::size_t Start, std::size_t End, std::size_t Inc = 1, typename F> | ||
| constexpr void constexpr_for(F&& f) { | ||
| if constexpr (Start < End) { | ||
| f(std::integral_constant<std::size_t, Start>()); | ||
| constexpr_for<Start + Inc, End, Inc>(std::forward<F>(f)); | ||
| } | ||
| } | ||
|
|
||
| template <std::size_t Idx, typename T> | ||
| struct CollectionLeaf { | ||
| CollectionLeaf() = default; | ||
| CollectionLeaf(std::byte* buffer, int32_t elements) : layout_(buffer, elements), view_(layout_) {} | ||
| template <std::size_t N> | ||
| CollectionLeaf(std::byte* buffer, std::array<int32_t, N> const& sizes) | ||
| : layout_(buffer, sizes[Idx]), view_(layout_) { | ||
| static_assert(N >= Idx); | ||
| } | ||
| using Layout = T; | ||
| using View = typename Layout::View; | ||
| using ConstView = typename Layout::ConstView; | ||
| Layout layout_; // | ||
| View view_; //! | ||
| // Make sure types are not void. | ||
| static_assert(not std::is_same<T, void>::value); | ||
| }; | ||
|
|
||
| template <std::size_t Idx, typename T, typename... Args> | ||
| struct CollectionImpl : public CollectionLeaf<Idx, T>, public CollectionImpl<Idx + 1, Args...> { | ||
| CollectionImpl() = default; | ||
| CollectionImpl(std::byte* buffer, int32_t elements) : CollectionLeaf<Idx, T>(buffer, elements) {} | ||
|
|
||
| template <std::size_t N> | ||
| CollectionImpl(std::byte* buffer, std::array<int32_t, N> const& sizes) | ||
| : CollectionLeaf<Idx, T>(buffer, sizes), | ||
| CollectionImpl<Idx + 1, Args...>(CollectionLeaf<Idx, T>::layout_.metadata().nextByte(), sizes) {} | ||
| }; | ||
|
|
||
| template <std::size_t Idx, typename T> | ||
| struct CollectionImpl<Idx, T> : public CollectionLeaf<Idx, T> { | ||
| CollectionImpl() = default; | ||
| CollectionImpl(std::byte* buffer, int32_t elements) : CollectionLeaf<Idx, T>(buffer, elements) {} | ||
|
|
||
| template <std::size_t N> | ||
| CollectionImpl(std::byte* buffer, std::array<int32_t, N> const& sizes) : CollectionLeaf<Idx, T>(buffer, sizes) { | ||
| static_assert(N == Idx + 1); | ||
| } | ||
| }; | ||
|
|
||
| template <typename... Args> | ||
| struct Collections : public CollectionImpl<0, Args...> {}; | ||
|
|
||
| // return the type at the Idx position in Args... | ||
| template <std::size_t Idx, typename... Args> | ||
| using TypeResolver = typename std::tuple_element<Idx, std::tuple<Args...>>::type; | ||
|
|
||
| // count how many times the type T occurs in Args... | ||
| template <typename T, typename... Args> | ||
| inline constexpr std::size_t typeCount = ((std::is_same<T, Args>::value ? 1 : 0) + ... + 0); | ||
|
|
||
| // count the non-void elements of Args... | ||
| template <typename... Args> | ||
| inline constexpr std::size_t membersCount = sizeof...(Args); | ||
|
|
||
| // if the type T occurs in Tuple, TupleTypeIndex has a static member value with the corresponding index; | ||
| // otherwise there is no such data member. | ||
| template <typename T, typename Tuple> | ||
| struct TupleTypeIndex {}; | ||
|
|
||
| template <typename T, typename... Args> | ||
| struct TupleTypeIndex<T, std::tuple<T, Args...>> { | ||
| static_assert(typeCount<T, Args...> == 0, "the requested type appears more than once among the arguments"); | ||
| static constexpr std::size_t value = 0; | ||
| }; | ||
|
|
||
| template <typename T, typename U, typename... Args> | ||
| struct TupleTypeIndex<T, std::tuple<U, Args...>> { | ||
| static_assert(not std::is_same_v<T, U>); | ||
| static_assert(typeCount<T, Args...> == 1, "the requested type does not appear among the arguments"); | ||
| static constexpr std::size_t value = 1 + TupleTypeIndex<T, std::tuple<Args...>>::value; | ||
| }; | ||
|
|
||
| // if the type T occurs in Args..., TypeIndex has a static member value with the corresponding index; | ||
| // otherwise there is no such data member. | ||
| template <typename T, typename... Args> | ||
| using TypeIndex = TupleTypeIndex<T, std::tuple<Args...>>; | ||
|
|
||
| // return the index where the type T occurs in Args... | ||
| template <typename T, typename... Args> | ||
| inline constexpr std::size_t typeIndex = TypeIndex<T, Args...>::value; | ||
|
|
||
| } // namespace portablecollection | ||
|
|
||
| #endif // DataFormats_Portable_interface_PortableCollectionCommon_h |
Oops, something went wrong.