Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TSG tests and Relval Steps to use new run3_[hlt|data]_relval GTs #37206

Merged

Conversation

Martin-Grunewald
Copy link
Contributor

PR description:

Update TSG tests and Relval Steps to use new run3_[hlt|data]_relval GTs

PR validation:

TSG tests

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #37184 needed for TSG/HLT use in 12_3

@Martin-Grunewald
Copy link
Contributor Author

backport of #37184

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 11, 2022

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_12_3_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @jordan-martins, @AdrianoDee, @bbilin, @wajidalikhan, @cmsbuild, @missirol, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @missirol, @silviodonato, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b60b90/23039/summary.html
COMMIT: 85dac94
CMSSW: CMSSW_12_3_X_2022-03-10-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37206/23039/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695161
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3695131
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@Martin-Grunewald
Copy link
Contributor Author

+1

@AdrianoDee
Copy link
Contributor

+upgrade
Backport of #37184

@Martin-Grunewald
Copy link
Contributor Author

pdmv L2s, can you please sign this backport PR?
Thanks!

@kskovpen
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 14, 2022

+1

@cmsbuild cmsbuild merged commit 5a61538 into cms-sw:CMSSW_12_3_X Mar 14, 2022
@missirol missirol deleted the UpdateTSGandRelvalGTsForRun3 branch April 30, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants