Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.3.X] Introduce alignment campaign-like unit test for pede #37226

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 13, 2022

backport of #37211

PR description:

As discussed here cms-sw/cmsdist#7660 (comment) introduce a pede execution based off a real (small-scale) MC alignment campaign (cosmics-only). The needed input files to steer the execution are at: /store/group/alca_global/tkal_millepede_tests/

PR validation:

run scram b runtests_testPedeCampaign, but at the moment (for reason that are being investigated) the pede execution gets stuck (starting from CMSSW_12_3_0_pre3 onwards), while it run fine in previous pre-releases. (The issue, due to a wrong commit for the pede spec file in cmsdist has been solved in cms-sw/cmsdist#7685)

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #37211

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 13, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_3_X.

It involves the following packages:

  • Alignment/MillePedeAlignmentAlgorithm (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich mmusich changed the title [12.3.X] Introduce real data unit test for pede [12.3.X] Introduce alignment campaign-like unit test for pede Mar 13, 2022
@mmusich
Copy link
Contributor Author

mmusich commented Mar 13, 2022

test parameters:

@mmusich
Copy link
Contributor Author

mmusich commented Mar 13, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d53a5/23076/summary.html
COMMIT: d02578e
CMSSW: CMSSW_12_3_X_2022-03-13-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37226/23076/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695161
  • DQMHistoTests: Total failures: 22
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3695116
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Mar 14, 2022

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Mar 15, 2022

what's the plan for inclusion of this PR?

@qliphy
Copy link
Contributor

qliphy commented Mar 15, 2022

what's the plan for inclusion of this PR?

see #37211 (comment)

@qliphy
Copy link
Contributor

qliphy commented Mar 16, 2022

+1

@cmsbuild cmsbuild merged commit 7693016 into cms-sw:CMSSW_12_3_X Mar 16, 2022
@mmusich mmusich deleted the addMillePedeTestingSetup_12_3_X branch March 16, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants