Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cosmics PCL workflow to runTheMatrix #40661

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 1, 2023

PR description:

Title says it all, in preparation to add a FPix LA PCL workflow (to be run in cosmics data-taking)

PR validation:

Run successfully runTheMatrix.py -l 1005.0 -t 4 -j 8

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@mmusich
Copy link
Contributor Author

mmusich commented Feb 1, 2023

test parameters:

  • enable_test = threading
  • workflows_threading = 1005.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40661/33994

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2023

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/AlCa (alca)
  • Configuration/PyReleaseValidation (pdmv, upgrade)

@malbouis, @yuanchao, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @saumyaphor4252, @kskovpen, @sunilUIET, @tvami, @ChrisMisan, @francescobrivio can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @tocheng, @mmusich, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Feb 1, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-458a72/30328/summary.html
COMMIT: 677b573
CMSSW: CMSSW_13_0_X_2023-01-31-2300/el8_amd64_gcc11
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40661/30328/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555495
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555470
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Feb 1, 2023

+alca

  • new wf 1005 ran fine

@sunilUIET
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-458a72/30337/summary.html
COMMIT: e32e15b
CMSSW: CMSSW_13_0_X_2023-01-31-2300/el8_amd64_gcc11
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40661/30337/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555495
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555470
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Feb 1, 2023

+alca

  • new wf passed (still)

@mmusich
Copy link
Contributor Author

mmusich commented Feb 3, 2023

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 can you please review and sign, so that this can be used in #40664 (after rebasing)?

@kskovpen
Copy link
Contributor

kskovpen commented Feb 3, 2023

+pdmv

@srimanob
Copy link
Contributor

srimanob commented Feb 3, 2023

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Feb 3, 2023

The new workflow 1005 runs. Let me just point out the following warning message that can be found in the log file of step2 for that workflow, as it may be of interest to its potential users:

%MSG-e Alignment:  TkAlCaRecoMonitor:ALCARECOTkAlCosmicsInCollisions0TTkAlDQM  01-Feb-2023 18:37:14 CET Run: 360336 Event: 422152
invalid trackcollection encountered!

@perrotta
Copy link
Contributor

perrotta commented Feb 3, 2023

+1

@mmusich
Copy link
Contributor Author

mmusich commented Feb 3, 2023

The new workflow 1005 runs. Let me just point out the following warning message that can be found in the log file of step2 for that workflow, as it may be of interest to its potential users:

%MSG-e Alignment:  TkAlCaRecoMonitor:ALCARECOTkAlCosmicsInCollisions0TTkAlDQM  01-Feb-2023 18:37:14 CET Run: >360336 Event: 422152
invalid trackcollection encountered!

thanks, there was a bug indeed, fixed at #40686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants