Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PileUpJetID] Backport of #41854 (Move average calculations outside of jet constituents loop) to 13_0_X #41870

Conversation

nurfikri89
Copy link
Contributor

Backport of #41854

####Original PR description:
This PR moves the average values calculations to outside of the jet constituents loop in PileupJetIdAlgo.cc.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2023

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for CMSSW_13_0_X.

It involves the following packages:

  • RecoJets/JetProducers (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @missirol, @yslai, @AnnikaStein, @jdamgov, @ahinzmann, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Jun 5, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3a5ba/32980/summary.html
COMMIT: a7e207d
CMSSW: CMSSW_13_0_X_2023-06-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41870/32980/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 54 lines from the logs
  • Reco comparison results: 296 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3315916
  • DQMHistoTests: Total failures: 4121
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3311773
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jun 6, 2023

+1

@cmsbuild cmsbuild merged commit 2c89b1c into cms-sw:CMSSW_13_0_X Jun 6, 2023
@nurfikri89 nurfikri89 deleted the portFrom132XTo130X_puIdFix_avgOutOfLoop branch June 7, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants