[13_0_X] Protect assignments of StripDetset() in StMeasurementDetSet::getDetSet()

[makortel]

PR description:

Backport of #41936 fixing additional race condition in StMeasurementDetSet::getDetSet().

PR validation:

None beyond #41936

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #41936

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_13_0_X.

It involves the following packages:

• DataFormats/Common (core)
• RecoLocalTracker/SiPixelClusterizer (reconstruction)
• RecoTracker/MeasurementDet (reconstruction)

@smuzaffar, @Dr15Jones, @makortel, @clacaputo, @cmsbuild, @mandrenguyen can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mroguljic, @missirol, @dkotlins, @ebrondol, @wddgit, @ferencek, @mtosi, @gpetruc, @mmusich, @threus, @dgulhan, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Protect assignments of StripDetset() in StMeasurementDetSet::getDetSet() #41936

[makortel]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25f74b/33313/summary.html
COMMIT: 0bc879b
CMSSW: CMSSW_13_0_X_2023-06-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42042/33313/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 263 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3317136
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3317108
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[makortel]

I want to see a few rounds more (multithreaded) tests in IBs for the master PR before signing (say over the weekend), assuming this fix would not be that urgent.

[perrotta]

backport of #41936

[makortel]

+core

IBs over the weekend didn't show any problems from #41936

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1