Run3-hcx344 Try to fix the issue of Layer 0 weight in HCAL in the version 13_0_X - backport of #42083

[bsunanda]

PR description:

Try to fix the issue of Layer 0 weight in HCAL in the version 13_0_X - backport of #42083

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #42083 in the master

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_13_0_X.

It involves the following packages:

• Geometry/HcalCommonData (geometry)

@civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @bsunanda can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Run3-hcx342 Try to fix the issue of HCAL hit relabeller #42083

[bsunanda]

@cmsbuild Please test

[cmsbuild]

Pull request #42092 was updated. @civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @bsunanda can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c90e95/33410/summary.html
COMMIT: f632779
CMSSW: CMSSW_13_0_X_2023-06-26-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42092/33410/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3317136
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3317111
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[perrotta]

The question raised by Salavat in the master version of this PR should get answered before any possible backport

[bsunanda]

The code in the repository is incomplete. So the new check in the ReLabellerCode for Layer0 weight is more complete and surely affects all multi-layer depth1 towers. It is a safer check and should be included in this release

[bsunanda]

+geometry

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

backport of #42083

[perrotta]

+1

• It backports from Run3-hcx342 Try to fix the issue of HCAL hit relabeller #42083 everything but the tests