[13.0.X] fix assignment of PVValHelper::phase in PrimaryVertexValidation

[mmusich]

backport of #42203

PR description:

Minor fix, to avoid having randomly assigned values of the phase_ variable at runtime. Also instead of emitting a warning, throw in case the phase_ is not defined properly.

PR validation:

Private checks.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #42203 for data analysis purposes.

[mmusich]

type bug-fix

[mmusich]

please test

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_0_X.

It involves the following packages:

• Alignment/OfflineValidation (alca)

@perrotta, @consuegs, @saumyaphor4252, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from fix assignment of PVValHelper::phase in PrimaryVertexValidation #42203

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26e521/33573/summary.html
COMMIT: 361d70e
CMSSW: CMSSW_13_0_X_2023-07-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42205/33573/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 242 lines from the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3317116
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3317088
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• tests pass
• "You potentially removed 242 lines from the logs" is expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

• "You potentially removed 242 lines from the logs" is expected

@tvami which log? Which lines? And why not in the master version of this PR, see #42203 (comment)?

[mmusich]

which log? Which lines? And why not in the master version of this PR

I don't think this PR can be responsible for any large change in the logs. The warning that I promoted to exception appears to be random as it was triggered by an uninitialized variable, therefore it might or might not have been present in the logs (but it is just one printout per job in some unit tests).

[perrotta]

Well, the size of the step3 log of wf 136.793 (e.g.) here in 13_0_X changes from 495 k in the baseline to 289 k with this PR.
It is not straightforward to me to understand which exact warnings were removed: however those logs contain a huge amount of errors from the TrajectoryState, and quite several of them may have been gone (I see a few were also modified).

One must notice that in the master all those warnings had already disappeared, and the size of those step3 logs is a (much cleaner) 19k.

[mmusich]

however those logs contain a huge amount of errors from the TrajectoryState, and quite several of them may have been gone (I see a few were also modified).

Nothing of this can come from this PR, if you are concerned open a separate issue. Otherwise please merge (after master is signed)!

[perrotta]

Nothing of this can come from this PR, if you are concerned open a separate issue. Otherwise please merge (after master is signed)!

I have no concerns, I just wanted to understand the message left here by @tvami

[tvami]

hi Andrea, I prob misunderstood where the warnings that Marco removed will show up. We should be all good with this PR. Thanks!

[perrotta]

+1