Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0.X] Added pileup scenario for 2023 simulation #42231

Merged
merged 1 commit into from
Jul 11, 2023
Merged

[13.0.X] Added pileup scenario for 2023 simulation #42231

merged 1 commit into from
Jul 11, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 11, 2023

backport of #42213

PR description:

This PR includes the information to simulate the pileup scenario for the 2023 simulation samples. We rely on part of RunC data (fills 8807 to 8901) to generate such pileup distribution. More details have been discussed in the PPD General Meeting (see link https://indico.cern.ch/event/1299290/).

PR validation:

The added code has been tested with CMSSW_13_2_0_pre2, using the root file /store/relval/CMSSW_13_0_0_pre4/RelValMinBias_13p6TeV/GEN-SIM/130X_mcRun3_2022_realistic_withNewBSFromEOY2022Data_v1_RV186-v1/00000/18441d91-eeb9-46a9-bc4a-f5c388ef5e27.root

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #42213 to 13.0.X for 2023 MC

@romeof @mmusich
preliminary pileup scenarios for 2023 simulation
455fbab 
details in the talk at PPD meeting https://indico.cern.ch/event/1299290/#5-pileup-profile-for-2023-mc-p

Update mix_2023_25ns_Fills_8807_8901_ProjectedPileup_PoissonOOTPU_cfi.py

Add 1 artificial bin to have 100 bins (0 to 99), consistently with other pileup distributions

Update Mixing.py

added line for 2023 pileup scenario

Update Mixing.py to work properly

Update Mixing.py for 2023 pileup

Rename mix_2023_25ns_Fills_8807_8901_ProjectedPileup_PoissonOOTPU_cfi.py to mix_2023_Fills_8807_8901_ProjectedPileup_PoissonOOTPU_cfi.py

Update Mixing.py removing extra spaces in line 133
@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Jul 11, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 11, 2023 •
edited
Loading

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • SimGeneral/MixingModule (simulation)

@perrotta, @rappoccio, @civanch, @mdhildreth, @cmsbuild, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @mmusich, @sameasy, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich mmusich mentioned this pull request Jul 11, 2023
Merged
@mmusich
Copy link
Contributor Author

mmusich commented Jul 11, 2023

please test

@civanch
Copy link
Contributor

civanch commented Jul 11, 2023

+1

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a7d99/33637/summary.html
COMMIT: 455fbab
CMSSW: CMSSW_13_0_X_2023-07-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42231/33637/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 220 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3286334
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3286309
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 3a30a14 into cms-sw:CMSSW_13_0_X Jul 11, 2023
@mmusich mmusich deleted the 2023PU_scenario_13_0_X branch July 12, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok fully-signed operations-approved orp-approved simulation-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_0_X
Development

Successfully merging this pull request may close these issues.
5 participants
@mmusich @cmsbuild @civanch @perrotta @romeof