Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Update skim config for 2023 data taking and skim wf #42232

Merged

Conversation

youyingli
Copy link
Contributor

Backport of #42107 and #42229

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 11, 2023

A new Pull Request was created by @youyingli (You-Ying Li) for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/Skimming (pdmv)

@cmsbuild, @bbilin, @srimanob, @sunilUIET, @AdrianoDee can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@youyingli
Copy link
Contributor Author

@sunilUIET, please test

@sunilUIET
Copy link
Contributor

please test

@perrotta
Copy link
Contributor

backport of #42229
(also #42107)

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c72786/33650/summary.html
COMMIT: 708ab7c
CMSSW: CMSSW_13_0_X_2023-07-11-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42232/33650/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially added 229 lines to the logs
  • Reco comparison results: 125 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3286334
  • DQMHistoTests: Total failures: 4112
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3282200
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@youyingli
Copy link
Contributor Author

@sunilUIET , could you please retrigger again as the timeout problem happens? Thanks!

@sunilUIET
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c72786/33664/summary.html
COMMIT: 708ab7c
CMSSW: CMSSW_13_0_X_2023-07-12-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42232/33664/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 10 lines to the logs
  • Reco comparison results: 121 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3286334
  • DQMHistoTests: Total failures: 4112
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3282200
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@youyingli
Copy link
Contributor Author

Hi @sunilUIET , @srimanob, please sign it if no other consideration. The backport to 13_1_X will be made after #42226 is merged.

@sunilUIET
Copy link
Contributor

+pdmv

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

@youyingli please take note of #42229 (comment) : perhaps, before backporting anothes PR with another fix should be merged in master?

In any case, a backport for the intermediate 13_1_X cycle should be prepared also

@youyingli
Copy link
Contributor Author

@youyingli please take note of #42229 (comment) : perhaps, before backporting anothes PR with another fix should be merged in master?

In any case, a backport for the intermediate 13_1_X cycle should be prepared also

Yes, I will take care of this issue and create new PRs to master, 13_1_X and 13_0_X. Could you please consider merging this PR in order to be included in the next CMSSW release and produce the new skim dataset for 2023 data taking?

@perrotta
Copy link
Contributor

Yes, I will take care of this issue and create new PRs to master, 13_1_X and 13_0_X. Could you please consider merging this PR in order to be included in the next CMSSW release and produce the new skim dataset for 2023 data taking?

We do not foresee building a new 13_0_X release in the next few days: please go ahead with integrating the fix a preparing the 13_1_X backport

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 94e5fb8 into cms-sw:CMSSW_13_0_X Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants