Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing PU for 2023 WFs with more reasonable profile #42295

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

sunilUIET
Copy link
Contributor

This PR updates the PU profile of 2023 WFs with a reasonable scenario Run3_Flat55To75_PoissonOOTPU. After merging here, this will be backported to 13_0_X and 13_1_X.

@sunilUIET
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42295/36319

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @sunilUIET (sunil bansal) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @srimanob, @sunilUIET, @AdrianoDee can you please review it and eventually sign? Thanks.
@makortel, @missirol, @slomeo, @fabiocos, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f5d3ba/33740/summary.html
COMMIT: 3c4a01a
CMSSW: CMSSW_13_2_X_2023-07-18-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42295/33740/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3195634
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3195601
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@sunilUIET
Copy link
Contributor Author

+pdmv

@srimanob
Copy link
Contributor

I assume we should see different in PR test, but not. This is because we don't have 2023 PU sample in the short matrix,
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/scripts/runTheMatrix.py#L94-L99

Should we use this PR to add 12634.0 and maybe remove 11834.0 ?

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@srimanob
Copy link
Contributor

We should have a following PR, to update the test workflow in the short matrix. I can have it in my next PR.

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fd02e83 into cms-sw:master Jul 20, 2023
@srimanob
Copy link
Contributor

srimanob commented Jul 24, 2023

Hi @sunilUIET

I don't see backport of this PR in 13_0/13_1/13_2 yet. Should I include backport to my FastSim backport PR, because it will overwrite this PR anyways? So that we can avoid small PRs.

This was referenced Jul 24, 2023
@sunilUIET
Copy link
Contributor Author

@srimanob please

@srimanob srimanob mentioned this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants